Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix pprof exposure on default mux - #431

Open
rschumann wants to merge 1 commit into
mainfrom
sentinel/fix-g108-pprof-exposure-12726261306313716324
Open

rschumann wants to merge 1 commit into
mainfrom
sentinel/fix-g108-pprof-exposure-12726261306313716324

Conversation

@rschumann

Copy link
Copy Markdown
Contributor

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Profiling endpoint is automatically exposed on the global /debug/pprof endpoints when importing net/http/pprof with a blank identifier.
🎯 Impact: Exposes sensitive internal application metrics, stack traces, and memory allocations via /debug/pprof/* endpoints on any port bound to http.DefaultServeMux, which could aid attackers in reconnaissance or cause DoS.
πŸ”§ Fix: Replaced the global blank import with explicit route registration on a dedicated isolated http.ServeMux for the pprof HTTP server, preventing accidental exposure on other default listeners.
βœ… Verification: Verified that gosec G108 is no longer flagged and go test ./... -short passes.


PR created automatically by Jules for task 12726261306313716324 started by @rschumann

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant