Skip to content

fix: support runtime secret files INF-177 - #65

Merged
chriszhao1988 merged 1 commit into
feat/add_job_deploymentfrom
fix/jwt-secret-file-injection-INF-177
Aug 21, 2026
Merged

chriszhao1988 merged 1 commit into
feat/add_job_deploymentfrom
fix/jwt-secret-file-injection-INF-177

Conversation

@chriszhao1988

Copy link
Copy Markdown
Contributor

Scope

Add an opt-in JSON mapping from AWS Secrets Manager fields to protected runtime files.

Security behavior

  • Mapped fields are excluded from .env.
  • Runtime files are created with mode 600 and transferred into the service deployment directory.
  • Runner-side .env and runtime files are removed even when deployment fails.
  • No secret value is present in this branch or PR.

Consumer

Datacenter PR #46 uses JWT_PRIVATE_KEY and JWT_PUBLIC_KEY for its development and testnet deployment paths.

Validation

  • YAML parse passed.
  • A synthetic fixture confirmed mapped fields do not enter .env and both generated files use mode 600.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4f7a7025-f04d-410f-a1fe-9d7eaeb0ffbe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chriszhao1988
chriszhao1988 marked this pull request as ready for review August 21, 2026 08:07
@chriszhao1988
chriszhao1988 merged commit eb0f6c2 into feat/add_job_deployment Aug 21, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant