Skip to content

fix: preserve secret file mapping INF-177 - #66

Merged
chriszhao1988 merged 1 commit into
feat/add_job_deploymentfrom
fix/secret-file-map-materialization-INF-177
Aug 21, 2026
Merged

chriszhao1988 merged 1 commit into
feat/add_job_deploymentfrom
fix/secret-file-map-materialization-INF-177

Conversation

@chriszhao1988

Copy link
Copy Markdown
Contributor

Incident follow-up

Datacenter development CD reached the reusable deployment workflow but failed before reading mapped JWT fields.

Root cause

The workflow piped the JSON mapping through jq type validation and redirected jq's boolean result into the mapping file. Later mapping iteration therefore received true instead of the JSON object.

Change

Write the original mapping JSON to the protected temporary mapping file, then validate that file separately as an object.

Validation

  • Workflow YAML parsed successfully.
  • A synthetic fixture exercised the exact write, validation, and lookup path; both JWT mapping entries remained available.
  • No Secrets Manager value or PEM content was read, logged, or committed.

Rollout

Merge this PR first. A new Datacenter develop push is then required to resolve the updated reusable workflow ref and retry deployment.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7a1f6bd2-479a-4055-8a8d-fa32f1165959

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chriszhao1988
chriszhao1988 marked this pull request as ready for review August 21, 2026 08:21
@chriszhao1988
chriszhao1988 merged commit 82be4ee into feat/add_job_deployment Aug 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant