fix: preserve secret file mapping INF-177 - #66
Merged
chriszhao1988 merged 1 commit intoAug 21, 2026
Merged
chriszhao1988 merged 1 commit into
chriszhao1988 merged 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chriszhao1988
marked this pull request as ready for review
August 21, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident follow-up
Datacenter development CD reached the reusable deployment workflow but failed before reading mapped JWT fields.
Root cause
The workflow piped the JSON mapping through jq type validation and redirected jq's boolean result into the mapping file. Later mapping iteration therefore received true instead of the JSON object.
Change
Write the original mapping JSON to the protected temporary mapping file, then validate that file separately as an object.
Validation
Rollout
Merge this PR first. A new Datacenter develop push is then required to resolve the updated reusable workflow ref and retry deployment.