Skip to content

fix: validate runtime RSA keypairs INF-177 - #67

Merged
chriszhao1988 merged 1 commit into
feat/add_job_deploymentfrom
fix/validate-rsa-secret-files-INF-177
Aug 24, 2026
Merged

chriszhao1988 merged 1 commit into
feat/add_job_deploymentfrom
fix/validate-rsa-secret-files-INF-177

Conversation

@chriszhao1988

Copy link
Copy Markdown
Contributor

Scope

Add an opt-in RSA private/public keypair validation gate for runtime secret files.

Behavior

  • Validates configured private and public paths before any SSH transfer or container shutdown.
  • Rejects invalid RSA PEMs and public keys that do not match the supplied private key.
  • Keeps secret contents out of logs and retains runner cleanup behavior.

Validation

  • Workflow YAML parsed successfully.
  • Synthetic RSA fixture accepted a matching pair and rejected a mismatched public key.

Consumer

Platform PR #44 adds the opt-in input for development, testnet, and mainnet deployments.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5378c47d-67b9-4207-92ad-48a72f6a8765

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chriszhao1988
chriszhao1988 marked this pull request as ready for review August 24, 2026 01:25
@chriszhao1988
chriszhao1988 merged commit b9ffaa6 into feat/add_job_deployment Aug 24, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant