Skip to content

fix: make frontend validation optional INF-180 - #68

Merged
chriszhao1988 merged 1 commit into
feat/add_job_deploymentfrom
fix/frontend-deployment-validation-INF-180-181
Aug 24, 2026
Merged

chriszhao1988 merged 1 commit into
feat/add_job_deploymentfrom
fix/frontend-deployment-validation-INF-180-181

Conversation

@chriszhao1988

@chriszhao1988 chriszhao1988 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Context

ServicesPlatform FE deploy-mainnet failed before packaging because the shared frontend workflow unconditionally called a missing validate:local script.

Change

Run validate:local only when the consuming repository defines it. Existing repositories that provide the script still execute it; repositories that do not can continue to the existing nginx checks and configured build command.

Validation

  • YAML parse passed.
  • git diff --check passed.
  • Target branch is feat/add_job_deployment, the exact feature ref consumed by the affected FE deployment workflow. main is intentionally not used as the base.

Follow-up

After merge, rerun ServicesPlatform FE deploy-mainnet for the already-merged cleanup revision, then verify deployment and public assets.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c23d8aff-c236-42df-8cdc-1a1255a2382b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chriszhao1988
chriszhao1988 marked this pull request as ready for review August 24, 2026 07:20
@chriszhao1988
chriszhao1988 merged commit 4fb09db into feat/add_job_deployment Aug 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant