Skip to content

Conversation

@rschiffer
Copy link
Contributor

@rschiffer rschiffer commented Mar 4, 2025

Open TODOs

  • Fix test setup (Roman/Clara T.)
    I think the tests are not working because jest is not configured for ESM imports (could be wrong of course) and hence the imports from @ark-ui/react fail
  • Migrate DatePicker (Roman)
  • Styling of DatePicker (Roman)
  • Migrate Slider (Lukas)
  • Migrate Select (Clara)
  • Migrate BoemlyFormControl (needed for the Slider) (Clara)
  • Fix TypeError in src/components/ui/slider.tsx
  • maybe add the dependencies @emotion/styled and framer-motion back again
  • Fix passing of color scheme (https://www.chakra-ui.com/docs/get-started/migration#colorscheme-prop)
  • Avatar: too small (Roman)
  • BoemlyAccordion (Clara)
  • BoemlySteps - Horizontal: Lines are missing (consider that "Divider" turned into "Separator") (Roman)
  • Gradient ( add blackAlpha to color palette (Roman))
  • MobileBurgerMenu (Clara)
  • Slider (Clara)
  • Select (Clara)
  • Progess - radius (Clara)
  • Separator - vertical not working (Roman)
  • Tooltip - styling (Clara)
  • OverflownText - Truncated: tooltip styling
  • ESLint

@vercel
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boemly Ready Ready Preview Comment Dec 9, 2025 1:17pm

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/boemly.cjs.production.min.js 0 B (-100% 🔽) 0 ms (-100% 🔽) 0 ms (-100% 🔽) 0 ms
dist/boemly.esm.js 0 B (-100% 🔽) 0 ms (-100% 🔽) 0 ms (-100% 🔽) 0 ms
0 B (+100% 🔺) 0 ms (+100% 🔺) 0 ms (+100% 🔺) 0 ms

@rschiffer rschiffer force-pushed the rbs/enable-boemly-react19 branch from 9452cf4 to 46552aa Compare March 5, 2025 12:25
@rschiffer rschiffer force-pushed the rbs/enable-boemly-react19 branch from d62207f to 6b91e0c Compare March 6, 2025 08:45
@rschiffer rschiffer force-pushed the rbs/enable-boemly-react19 branch from f2bee65 to b0c1bff Compare March 17, 2025 19:54
@ClaraTschamon ClaraTschamon self-requested a review March 20, 2025 10:31
@ClaraTschamon
Copy link
Contributor

ClaraTschamon commented Nov 21, 2025

Generel:

  • image This should be white and green I think

that is just the new storybook design in dark-mode. In light-mode it looks like before. I updated storybook to v10...

Components:

  • BoemlyAccordion: The button does turn in the other direction now

=> I don't care. That's default chakra-ui behaviour.

  • BoemlyAccordion: The mouse pointer does not change when hovering over the button

=> That's also default Chakra-UI behaviour. Also on production boemly it's the same. I tried to change it but I just can't override the default cursor.

  • BoemlyAccordion: Variants black and white must take Storybook light and dark theme into account

=> good catch. i didn't see that after the storybook update

  • BoemlyFormControl: NumberInput => button (on the right of intput field) radius does not align with input field radius
  • BoemlyFormControl: Select => arrow is a little bit more left now
  • BoemlyFormControl: Checkbox => styling of label is different (font-size, font-weight)
image

This was default text styling.... The default textstyling changed (left v2, right v3).
I now defined the text styles to

  • smLowNormal,
  • mdLowNormal,
  • lgLowNormal and
  • xlLowNormal... depending on the size of the checkbox.
  • BoemlyFormControl: Radio => styling of label is different (font-size, font-weight)
image =>Same as for the checkbox... the default text styling of chakra components changed and I now defined the labels using our boemly fonts...
  • BoemlyFormControl: DatePicker => gray background on hover is gone
  • BoemlyFormControl: StatesOverview => valid state is missing green checkmark
  • BoemlyModal: Font sizes are different
image => Also here the defaults changed.
  • BoemlySteps: Green color is different
image => This is because we used the green color scheme from chakraui. Here the color green.500 changed.
  • ConfirmAction: Variant with loading button is not working
    => good catch! this was already broken on production

@ClaraTschamon
Copy link
Contributor

I replaced the react-use package with usehooks because the problem was that it was was not compatible anymore

streamich/react-use#2614

@ClaraTschamon
Copy link
Contributor

TODO: mark as Breaking Change

@ClaraTschamon
Copy link
Contributor

This was the reason why we switched away from react-use to usehooks
image

BREAKING CHANGE: upgraded Chakra from v2 to v3
@ClaraTschamon ClaraTschamon merged commit cf53d89 into main Dec 9, 2025
7 checks passed
@ClaraTschamon ClaraTschamon deleted the rbs/enable-boemly-react19 branch December 9, 2025 13:28
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released wip Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants