Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ name: Build
on:
workflow_dispatch:
pull_request:
# Runs on master so each merge records the APK metrics that pull requests are
# Runs on main so each merge records the APK metrics that pull requests are
# compared against. Without this there is no baseline and the size report on a PR
# can only show absolute numbers.
push:
branches:
- master
- main

permissions:
contents: read
# Needed to list master's workflow runs and download their metrics artifact
# Needed to list main's workflow runs and download their metrics artifact
actions: read

jobs:
Expand Down Expand Up @@ -126,13 +126,13 @@ jobs:

# Best effort: a first run, a deleted artifact or an expired retention window all just
# mean there is no baseline to compare against, which is not a reason to fail the build.
- name: Fetch baseline metrics from master
- name: Fetch baseline metrics from main
if: github.event_name == 'pull_request'
continue-on-error: true
env:
GH_TOKEN: ${{ github.token }}
run: |
run_id=$(gh run list --workflow build.yml --branch master --status success \
run_id=$(gh run list --workflow build.yml --branch main --status success \
--limit 1 --json databaseId --jq '.[0].databaseId')
if [ -n "$run_id" ]; then
gh run download "$run_id" --name apk-metrics --dir baseline
Expand All @@ -147,8 +147,8 @@ jobs:
if [ -f baseline/apk-metrics.json ]; then
python3 scripts/apk-metrics.py compare baseline/apk-metrics.json apk-metrics.json
else
echo "No master baseline available yet, so this run reports absolute numbers only."
echo "A baseline is recorded on the next push to master."
echo "No main baseline available yet, so this run reports absolute numbers only."
echo "A baseline is recorded on the next push to main."
echo
echo '```json'
cat apk-metrics.json
Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ audio sync, decoder behaviour — document it there with the symptom to check, a
alone until someone can verify it.

CI runs unit tests as a job independent of the build, and reports APK size and DEX method count
against master (`scripts/apk-metrics.py`). Those two numbers are the only performance signal CI
against main (`scripts/apk-metrics.py`). Those two numbers are the only performance signal CI
can honestly provide; they move when the shrinker config or dependency tree changes.

---
Expand Down
2 changes: 1 addition & 1 deletion HARDWARE_TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ it is switched on.
> hardware time than has gone into it.
>
> Source: commit `810858bf` on `feature/audio-observability`, which also carries the readback
> instrumentation the measurement depends on. That instrumentation is **not** on master, so
> instrumentation the measurement depends on. That instrumentation is **not** on main, so
> reproducing these numbers here means building that branch.

---
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Taken on an Android TV box streaming Steam from Sunshine.
* Raising minSdk to 30 removed 111 OS-version checks and the rooted build flavour; the branch is
roughly 48,000 lines lighter than upstream.
* A JVM unit test suite (`./gradlew testDebugUnitTest`) with coverage, run by CI alongside the
build; CI also reports APK size and DEX method count against master.
build; CI also reports APK size and DEX method count against main.

### Removed

Expand Down
Loading