test(splitter): add boundary tests for splits_of_paged (#325) - #403
Merged
Spagero763 merged 3 commits intoJul 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
splits_of_pagedhad no tests. Pagination logic is exactly the kind of code that silently breaks at its boundaries. This PR adds four test cases covering all edge cases identified in #325.Changes
Added 4 tests to
contracts/splitter/src/test.rs:splits_of_paged_start_beyond_list_length— verifies that a start index equal to or greater than the list length returns an empty pagesplits_of_paged_limit_zero— verifies that a limit of 0 returns an empty page regardless of startsplits_of_paged_runs_past_end— verifies that when fewer items remain than the requested limit, the page correctly stops at the end of the listsplits_of_paged_lands_exactly_on_last_item— verifies that a start + limit landing exactly on the last item returns that single itemCI
cargo fmt— cleancargo clippy --all-targets -- -D warnings— cleancargo test— all 68 tests passCloses #325