docs(agents): record the riptide-emission and cost invariants - #187
Merged
Merged
Conversation
Style was already terse; what was missing were invariants the code enforces and that cost real debugging to find: emission is best-effort, the rollup is claimed before the POST so a rejected one is never retried (hence deploy riptide first when adding a field), an unknown cost is omitted rather than zeroed or dropped, we declare our own account, and a None cost fails open. Also notes that the disagree mechanic was removed deliberately in 009, so it does not get reintroduced by someone reading the older docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file was already terse and rule-shaped — nothing to compress. What it lacked were invariants, several of which cost real debugging to establish:
riptide_emitted_atis stamped by the statement that reads the snapshot, so a rejected emission is never retried — which means a payload riptide's strict schema rejects 422s every rollup, not just the one carrying a new field. Hence: deploy the riptide side first when adding a field. This is exactly what would have bitten us on fix(riptide): report the reviewer account, stop dropping unpriced rollups #186.Nonecost fails open — an unpriced model must never block a review; the per-PR cap skips only subsequent auto-runs.009, noted so nobody reinstates it from older docs.1 331 → 3 151 chars, still well inside budget. Docs only; 649 tests pass.
Candidates I did not add, because they need a proper read of the review path rather than a passing look: the deadline-exceeded summary rules, the "never post an empty summary" rule, and the network-error-does-not-mark-ignored rule. Worth a follow-up pass.