Trust the git host service-account flag - #67
Merged
Merged
Conversation
Bitbucket DC marks its built-in system user `type: SERVICE` - the account that files the default PR tasks and posts stale-PR notices. Those comments land within a second of a PR opening, so counted as human they make review pickup time look instant; in production data that account is the first non-author touch on 81 PRs, all at zero seconds. The parser now carries that flag and detection tags such rows `automation_source = 'service-account'`. Checked after the configured sources, so a configured bot keeps its own name, and no installation has to list a server-side account it never created.
trick77
changed the title
A service account whose handle looks bot-shaped (`ci-bot`) was tagged `other-bot`, which would put a technical user into bot-velocity views - those exist to show work bots actually author. A stated fact beats a guess from the name, so the SERVICE check now sits above `looks_bot_shaped`, still below the configured sources, which name the specific tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitbucket DC marks its built-in system user as
type: SERVICE— the account that files the default PR tasks and posts stale-PR notices. It is not an account anyone creates, and no config lists it, so it counted as a human reviewer.In the production export that account posts 85 comments across 10 repos, 81 of them within 5 seconds of a PR opening (
severity: BLOCKERdefault tasks). That makes it the first non-author touch on 81 PRs, all at zero seconds — the second-largest distortion of code-review pickup time after the review bot itself.The parser now carries Bitbucket's own verdict and detection tags those rows
automation_source = "service-account". It is checked after the configured sources, so a configured bot keeps its own name; absence oftypenever promotes a person.This is config-last by design: prefer what the payload already states, then what senders declare about themselves, and only then a config entry. Renovate still needs one (Bitbucket reports it as
NORMALand it sends nothing to riptide).Tests: 234 pass, ruff + basedpyright clean.