Specify non-solar abundance patterns - #224
Open
clairekope wants to merge 5 commits into
Open
Conversation
reading_func_args accessed by SpectrumGenerator changed some variable names bc I thought trident was confused but alas it is me who is confused (cue billy joel frog) Change how we pass abundances heyo Propogated changes to spec gen Added abundance table args to ray generators No method has_key :( abundance_store not being set; attempt fix abundance_store not being set; attempt fix GLOBAL VARIABLES ARE DUMB Let's be explicit with all our globals beginning of final modifications got ri of print statements and commented out parts of reading function I probably do not need anymore some_rad_science is only commented out right now I think she is finally done
Coverage Report for CI Build 0Coverage increased (+0.08%) to 76.132%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions78 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
Collaborator
|
Hi @clairekope . Thanks for the PR. I'll take a more detailed look at this PR soon. I think in general, it is worthwhile functionality, but it seems like you touch a lot of code here, and I think this could be simplified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users to specify alternative abundances for elements that are inferred from a general "metallicity" field. These abundances may be specified individually; if so, elements that are not specified during this override default to the previously used solar abundances.