wip: missing handler - #801
Open
jbr wants to merge 1 commit into
Open
Conversation
Contributor
Public API ChangesChanges to
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
- Coverage 68.92% 68.79% -0.13%
==========================================
Files 337 338 +1
Lines 19315 19352 +37
==========================================
+ Hits 13312 13313 +1
- Misses 6003 6039 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A possible but awkward way of addressing #688, but as mentioned in that issue, the correct solution is probably to implement this in applications and make the current behavior clearly documented.
This sort of opinionated behavior probably indicates that State should be removed from trillium-api entirely and instead lean on derive macros