Skip to content

wip: missing handler - #801

Open
jbr wants to merge 1 commit into
mainfrom
api-missing-handler
Open

wip: missing handler#801
jbr wants to merge 1 commit into
mainfrom
api-missing-handler

Conversation

@jbr

@jbr jbr commented May 3, 2026

Copy link
Copy Markdown
Contributor

A possible but awkward way of addressing #688, but as mentioned in that issue, the correct solution is probably to implement this in applications and make the current behavior clearly documented.

This sort of opinionated behavior probably indicates that State should be removed from trillium-api entirely and instead lean on derive macros

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Public API Changes

Changes to trillium-api
pub fn trillium_api::missing_handler(handler: impl trillium::handler::Handler) -> impl trillium::handler::Handler
pub type T::Error = ()trillium_api::missing_handler::MissingHandler

@codecov

codecov Bot commented May 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.87805% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.79%. Comparing base (34c8e5b) to head (5d32fc7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
api/src/missing_handler.rs 0.00% 34 Missing ⚠️
api/src/try_from_conn.rs 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
- Coverage   68.92%   68.79%   -0.13%     
==========================================
  Files         337      338       +1     
  Lines       19315    19352      +37     
==========================================
+ Hits        13312    13313       +1     
- Misses       6003     6039      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant