Skip to content

[FEAT] Notify outbound webhook of Sunrise reviews - #351

Merged
chris-okuda merged 2 commits into
mainfrom
chrisokuda/sc-40091/sunrise_webhooks
Aug 11, 2026
Merged

[FEAT] Notify outbound webhook of Sunrise reviews#351
chris-okuda merged 2 commits into
mainfrom
chrisokuda/sc-40091/sunrise_webhooks

Conversation

@chris-okuda

Copy link
Copy Markdown
Collaborator

Scope of changes

Send Sunrise accept and reject decisions to the configured outbound webhook after the review is committed.

  • Share the existing webhook handler with the web server
  • Add Sunrise webhook request construction and state mapping
  • Add mock webhook coverage for accepted and rejected reviews

Fixes SC-40091

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

A test was added using a mock webhook that should validate this feature.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have added new test fixtures as needed to support added tests
  • I have added or updated the documentation
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)

Send Sunrise accept and reject decisions to the configured outbound
webhook after the review is committed.

- Share the existing webhook handler with the web server
- Add Sunrise webhook request construction and state mapping
- Add mock webhook coverage for accepted and rejected reviews
@chris-okuda chris-okuda self-assigned this Aug 11, 2026
@chris-okuda
chris-okuda requested a review from eschmier August 11, 2026 00:35
@chris-okuda
chris-okuda merged commit bc3b96c into main Aug 11, 2026
8 checks passed
@chris-okuda
chris-okuda deleted the chrisokuda/sc-40091/sunrise_webhooks branch August 11, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant