refactor: Centralized implementation for GetElementCount and GetByteSize#121
Draft
yinggeh wants to merge 6 commits into
Draft
refactor: Centralized implementation for GetElementCount and GetByteSize#121yinggeh wants to merge 6 commits into
GetElementCount and GetByteSize#121yinggeh wants to merge 6 commits into
Conversation
yinggeh
changed the title
yinggeh
changed the title
GetElementCount and GetByteSize
mc-nv
reviewed
Apr 7, 2026
|
|
||
| #include "triton/backend/backend_common.h" | ||
|
|
||
| #include "triton/common/model_config.h" |
Contributor
There was a problem hiding this comment.
I believe this inclusion should be optional, otherwise if we wan't all backends to inherit it we need to add those enabled in CMake config by default.
Suggested change
| #include "triton/common/model_config.h" | |
| #if defined(TRITON_COMMON_ENABLE_PROTOBUF) || defined(TRITON_COMMON_ENABLE_GRPC) | |
| #include "triton/common/model_config.h" | |
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.