Skip to content

feat: Add `.MemberIsNullIs[type] Functions to TritonJson #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whoisj merged 4 commits into from
May 5, 2026
Merged

feat: Add `.MemberIsNullIs[type] Functions to TritonJson #157

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1d963e
feat: Add .MemberIsNullIs[type] Functions to TritonJson
whoisj Apr 1, 2026
93fbfe6
Potential fix for pull request finding
whoisj May 4, 2026
b468507
Potential fix for pull request finding
whoisj May 4, 2026
10ec4b3
Potential fix for pull request finding
whoisj May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions include/triton/common/triton_json.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,65 @@ class TritonJsonImpl {
return TRITONJSON_STATUSSUCCESS;
}

bool MemberIsArray(const char* name) const
{
const rapidjson::Value& object = AsValue();
if (!object.IsObject() || !object.HasMember(name)) {
Copy link
Copy Markdown
Contributor

@yinggeh yinggeh May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. We should never do no-block one-liner.

return false;
}
const auto& v = object[name];
return v.IsArray();
}

bool MemberIsArray(const std::string& name) const
{
return MemberIsArray(name.c_str());
}

bool MemberIsNull(const char* name) const
{
const rapidjson::Value& object = AsValue();
if (!object.IsObject() || !object.HasMember(name)) {
return false;
}
const auto& v = object[name];
return v.IsNull();
}

bool MemberIsNull(const std::string& name) const
{
return MemberIsNull(name.c_str());
}

bool MemberIsObject(const char* name) const
{
const rapidjson::Value& object = AsValue();
if (!object.IsObject() || !object.HasMember(name))
return false;
const auto& v = object[name];
Comment thread
whoisj marked this conversation as resolved.
return v.IsObject();
}

bool MemberIsObject(const std::string& name) const
{
return MemberIsObject(name.c_str());
}

bool MemberIsString(const char* name) const
{
const rapidjson::Value& object = AsValue();
if (!object.IsObject() || !object.HasMember(name)) {
return false;
}
const auto& v = object[name];
return v.IsString();
}

bool MemberIsString(const std::string& name) const
{
return MemberIsString(name.c_str());
}
Comment thread
whoisj marked this conversation as resolved.

bool IsString()
{
const rapidjson::Value& object = AsValue();
Expand Down
Loading