Skip to content

post: Update default branch post-26.05#194

Open
mc-nv wants to merge 1 commit into
mainfrom
mchornyi/TRI-1063/update-default-branch
Open

post: Update default branch post-26.05#194
mc-nv wants to merge 1 commit into
mainfrom
mchornyi/TRI-1063/update-default-branch

Conversation

@mc-nv
Copy link
Copy Markdown
Contributor

@mc-nv mc-nv commented May 27, 2026

CI (internal): #52829374

What does the PR do?

Cherry-pick of r26.05#191 ("fix: streamline library distribution for 26.05 upstream container build") to main: removes an absent reference and changes library distribution out of the PyTorch image. Required so main can build against the 26.05 upstream container.

Changed files: CMakeLists.txt.

Checklist

  • I have made sure this PR is not a duplicate.
  • I have made sure the commit message is clear and follows Conventional Commits.
  • I have added unit tests for any new functionality.
  • I have made sure all tests are passing.
  • For documentation changes: I have previewed the changes and they render correctly.

Commit Type:

  • feat (A new feature)
  • fix (A bug fix)
  • docs (Documentation-only changes)
  • style (Changes that do not affect the meaning of the code — formatting, whitespace, etc.)
  • refactor (A code change that neither fixes a bug nor adds a feature)
  • perf (A code change that improves performance)
  • test (Adding missing tests or correcting existing tests)
  • build (Changes that affect the build system or external dependencies)
  • ci (Changes to CI configuration files and scripts)
  • chore (Other changes that don't modify src or test files)

Related PRs:

Original (r26.05): #191

Where should the reviewer start?

CMakeLists.txt

Test plan:

Cherry-pick of an already-merged fix on r26.05; verified against the 26.05 upstream container build.

  • CI Pipeline ID: 52829374

Caveats:

Cherry-pick from r26.05.

Background

Part of TRI-1063 post-26.04 release maintenance: forward-port the 26.05 library-distribution fix so main builds cleanly against the 26.05 upstream container.

Related Issues:

Resolves: TRI-1063

…ld (#191)

* fix: Remove absent reference

* Change library distribution out of PyTorch image
@mc-nv mc-nv self-assigned this May 27, 2026
@mc-nv mc-nv changed the title fix: streamline library distribution for 26.05 upstream container build (cherry-pick) post: Update default branch post-26.05 May 27, 2026
@mc-nv mc-nv marked this pull request as ready for review May 27, 2026 20:32
@mc-nv mc-nv removed the cherry-pick label May 27, 2026
Comment thread CMakeLists.txt
set(TORCHVISION_LIBS
$<IF:$<BOOL:${RHEL_BUILD}>,libjpeg.so.62,libjpeg.so>
$<IF:$<BOOL:${RHEL_BUILD}>,libpng16.so.16,libpng16.so>
libjpeg.so.62
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's happening here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a change on PyTorch side.
We review the changes inside the container and libraries dependency to address names which are used by PyTorch.
For now this condition satisfies the build scenario, next release may or may not require respective change.

@mc-nv mc-nv requested a review from whoisj May 27, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants