post: Update default branch post-26.05#194
Open
mc-nv wants to merge 1 commit into
Open
Conversation
…ld (#191) * fix: Remove absent reference * Change library distribution out of PyTorch image
15 tasks
This was referenced May 27, 2026
whoisj
reviewed
May 27, 2026
| set(TORCHVISION_LIBS | ||
| $<IF:$<BOOL:${RHEL_BUILD}>,libjpeg.so.62,libjpeg.so> | ||
| $<IF:$<BOOL:${RHEL_BUILD}>,libpng16.so.16,libpng16.so> | ||
| libjpeg.so.62 |
Contributor
Author
There was a problem hiding this comment.
There was a change on PyTorch side.
We review the changes inside the container and libraries dependency to address names which are used by PyTorch.
For now this condition satisfies the build scenario, next release may or may not require respective change.
whoisj
approved these changes
May 27, 2026
yinggeh
approved these changes
May 27, 2026
nv-rinig
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI (internal): #52829374
What does the PR do?
Cherry-pick of
r26.05#191 ("fix: streamline library distribution for 26.05 upstream container build") tomain: removes an absent reference and changes library distribution out of the PyTorch image. Required somaincan build against the26.05upstream container.Changed files:
CMakeLists.txt.Checklist
Commit Type:
feat(A new feature)fix(A bug fix)docs(Documentation-only changes)style(Changes that do not affect the meaning of the code — formatting, whitespace, etc.)refactor(A code change that neither fixes a bug nor adds a feature)perf(A code change that improves performance)test(Adding missing tests or correcting existing tests)build(Changes that affect the build system or external dependencies)ci(Changes to CI configuration files and scripts)chore(Other changes that don't modify src or test files)Related PRs:
Original (r26.05): #191
Where should the reviewer start?
CMakeLists.txtTest plan:
Cherry-pick of an already-merged fix on
r26.05; verified against the 26.05 upstream container build.Caveats:
Cherry-pick from
r26.05.Background
Part of TRI-1063 post-26.04 release maintenance: forward-port the 26.05 library-distribution fix so
mainbuilds cleanly against the 26.05 upstream container.Related Issues:
Resolves: TRI-1063