test: Add python backend tests for the new histogram metric#7540
Merged
Conversation
… yinggeh-DLIS-7061-add-vllm-metrics
… yinggeh-DLIS-7061-add-vllm-metrics
rmccorm4
reviewed
Aug 16, 2024
rmccorm4
reviewed
Aug 16, 2024
rmccorm4
reviewed
Aug 16, 2024
rmccorm4
reviewed
Aug 16, 2024
rmccorm4
previously approved these changes
Aug 16, 2024
Contributor
rmccorm4
left a comment
rmccorm4
left a comment
There was a problem hiding this comment.
LGTM for cherry-pick purposes, but some comments for improving the tests later on.
…hub.com:triton-inference-server/server into yinggeh-DLIS-7113-support-histogram-metric-type
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rmccorm4
previously approved these changes
Aug 16, 2024
Contributor
|
Please trigger a pipeline encapsulating all the latest changes so can feel confident in the CI impact when looking at the cherry-picks |
rmccorm4
reviewed
Aug 16, 2024
Contributor
Author
|
Merged #7525 to the wrong branch. Need re-approval to merge to main. |
rmccorm4
reviewed
Aug 16, 2024
rmccorm4
approved these changes
Aug 17, 2024
yinggeh
changed the title
mc-nv
pushed a commit
that referenced
this pull request
Aug 19, 2024
mc-nv
added a commit
that referenced
this pull request
Aug 19, 2024
pvijayakrish
pushed a commit
that referenced
this pull request
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Tests histogram metric in custom_metrics.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/vllm_backend#56
triton-inference-server/python_backend#374
triton-inference-server/core#386
Where should the reviewer start?
n/a
Test plan:
n/a
17487728
Caveats:
n/a
Background
Customer requested histogram metrics from vLLM.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
n/a