fix: Reject Triton reserved keys in parameters and forward headers#8763
Merged
yinggeh merged 2 commits intoMay 6, 2026
Merged
Conversation
…RI-854) When the header-forward pattern matched a Triton-reserved name (e.g. `sequence_id`, `priority`, `binary_data_output`), a client could silently overwrite internal request parameters. Both HTTP and gRPC header-forwarding paths now reject any key in `kReservedParameterKeys` or with a `triton_` prefix. Adds `binary_data_output` to the reserved list in docs and expands the L0_parameters test suite with explicit rejection test cases.
yinggeh
force-pushed
the
yinggeh/tri-854-psirt-triton-http-parameter-injection-via-header-forwarding
branch
from
01b9763 to
4961352
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yinggeh
changed the title
whoisj
approved these changes
May 4, 2026
yinggeh
deleted the
yinggeh/tri-854-psirt-triton-http-parameter-injection-via-header-forwarding
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Reject Triton reserved keys in parameters and forward headers in HTTP and gRPC.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/client#894
Where should the reviewer start?
Test plan:
50210103
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)