fix: bind remote Claude agents to native CLI - #1
Conversation
Signed-off-by: Troy Hoffman <troy.hoffman@icloud.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 303b48f819
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| claude_cli="" | ||
| case "${{harness##*/}}" in | ||
| claude-agent-acp|claude-code-acp) |
There was a problem hiding this comment.
Apply the native Claude binding to remote model probes
When the create dialog selects a remote Claude harness, discover.rs::models_script still invokes buzz-acp models --json without resolving or exporting CLAUDE_CODE_EXECUTABLE. Consequently, model discovery continues to use the adapter's bundled Claude binary while the deployed service uses the native launcher resolved here, so the catalog/authentication check can describe a different Claude installation than the one that actually handles turns. Reuse this resolution and binding in the remote probe path as well.
Useful? React with 👍 / 👎.
Summary
CLAUDE_CODE_EXECUTABLEagainst persona/user overridesVerification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test -p buzz-backend-ssh(107 passed)sh -n,dash -n, ShellCheck,git diff --checkExisting branch-wide and infrastructure gate failures
The remaining red checks are unrelated to this five-file change:
desktop/src-tauri/src/events.rsis 1,011 lines against a 1,000-line limitbuzz-db: unchanged nanosecond timestamp precision assertion inreplica_fence::tests::fence_starts_closed_and_opens_on_advancedesktop/src-tauri/src/huddle/pipeline.rsfails the desktop Tauri rustfmt checkspin0.9.8/0.10.0 lockfile entriescargo fetchpermission_deniedfor the GitHub installation