Fix dropdown margins#159
Open
Folkman wants to merge 1 commit into
Open
Conversation
Folkman
force-pushed
the
fix_dropdown_margins
branch
from
8738ee7 to
72fd27f
Compare
markhalliwell
suggested changes
Sep 23, 2019
|
|
||
| // Collapse dropdown after large search results | ||
| this.plugin.$element.nextAll('.dropdown-menu') | ||
| .find('ul.dropdown-menu.inner') |
Contributor
There was a problem hiding this comment.
This traverses the DOM each time. DOM elements should get their own property on the object that can be targeted for performance reasons.
| // Collapse dropdown after large search results | ||
| this.plugin.$element.nextAll('.dropdown-menu') | ||
| .find('ul.dropdown-menu.inner') | ||
| .css({ margin: 0 }); |
Contributor
There was a problem hiding this comment.
I'm not a huge fan of using jQuery/JavaScript to style elements. This almost feels like fixing a symptom rather than the actual cause.
Contributor
|
Please base PRs agains the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
This solves the issue resulting from the
virtualScrolloption of bootstrap-select that adds top and bottom margins to the inner dropdown in order to simulate a long list without loading all the option elements in the DOM. When performing another search that is shorter, the margins need to be reset.Screenshots (optional)
Before
After
Closes Issue (optional)
Closes #156
Merge checklist (required, for maintainers only)
This pull request adheres to the following requirements: