Repository navigation
lgnome 0.5.5 - #3
Merged
Merged
Conversation
Owner
Author
|
@codex review |
Closed
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lgnome 0.5.5 fixes GNOME connections that stop during a daemon handoff and makes remote-access permission failures explicit in the HUB.
Validation: 68 Rust native tests, 74 host CTests, native syntax/logging checks, Rust formatting and the full webOS cross-build/package verification passed. Both connection regression tests failed before their fixes. The authorization regression also covers fragmented input and preservation of subsequent PDU bytes. Workflow YAML and all existing triggers/jobs were validated.
This is one cumulative snapshot above v0.5.4, exported from tested Bitbucket main. The public backend_ndl pin has the same tree as the tested development pin. The app ID remains com.truebest.lgnome.native; ordinary updates retain saved profiles.
The application code is identical to the previous candidate. The reported media-teardown issue was checked against DynamicVirtualChannel::drop in pinned IronRDP and two focused camera/audio probes; the teardown analysis explains why stale generations are rejected. This candidate additionally fixes the CI trigger and receives a fresh GitHub Codex review.
Bitbucket source CI and GitHub PR CI passed, including webOS package builds. GitHub Codex reviewed this commit and reported no major issues. All three required PR checks are green.