Rename trueforge mtls env vars - #841
Merged
Merged
Conversation
chiragjn
requested review from
bhaveshpatel640,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 22, 2026 10:04
🦋 Changeset detectedLatest commit: f399713 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thesujai
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Breaking rename for anyone still setting the old env vars outside the chart; misconfiguration would disable mTLS or leave HTTPS/client-cert enforcement off until vars are updated.
Overview
Renames the TrueForge process mTLS settings from
TRUEFORGE_MTLS_ENABLED/TRUEFORGE_MTLS_CERTS_DIRtoMTLS_ENABLED/MTLS_CERTS_DIR, so they are not confused with ServiceFoundry outbound mTLS (TRUEFOUNDRY_MTLS_*). Behavior is unchanged: distributed mode still serves HTTPS with client-cert enforcement (except/healthz), and the schedule controller still presents a client cert when callingSERVER_URL.The rename is wired through config parsing, TLS helpers, server startup, client-cert middleware, and the HTTP schedule executor. The Helm chart now injects the new names when
mtls.enabledis true, and docs /.env.exampleare updated accordingly.Also adjusts the assistant-runtime migration changeset semver from major to minor for the UI/runtime packages.
Reviewed by Cursor Bugbot for commit f399713. Bugbot is set up for automated code reviews on this repo. Configure here.