chore(AGE-1986): make sandbox provider fields provider-agnostic - #855
Merged
govindavashishtha merged 3 commits intoSep 23, 2026
Merged
govindavashishtha merged 3 commits into
govindavashishtha merged 3 commits into
Conversation
Move Daytona lifecycle fields off the shared sandbox base onto host DaytonaSandboxConfig so other providers are not forced to supply them. Co-authored-by: Cursor <cursoragent@cursor.com>
govindavashishtha
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry,
sr07asthana,
thesujai and
vinit-truefoundry
as code owners
September 23, 2026 06:10
🦋 Changeset detectedLatest commit: 0bf8835 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…provider-agnostic
harshil-2096
approved these changes
Sep 23, 2026
…provider-agnostic
govindavashishtha
enabled auto-merge (squash)
September 23, 2026 11:38
govindavashishtha
deleted the
chore/AGE-1986/make-sandbox-provider-fields-provider-agnostic
branch
September 23, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execTimeoutMs, auto-stop/archive/delete intervals) from shared sandbox port types inassistant-ui-runtimeDaytonaSandboxConfigon the trueforge-ui Daytona adapter, form, and settingsTest plan
pnpm --filter @truefoundry/trueforge-assistant-ui-runtime typecheckpnpm --filter @truefoundry/trueforge-ui typecheckpnpm --filter @truefoundry/trueforge-ui exec vitest run test/plugins/trueforge-agent-server-adapter/catalogs/sandboxProviderCatalog.test.ts test/containers/SettingsBuilder/SandboxSettings.test.tsxMade with Cursor