Skip to content

Keep composer interactive and preserve superseded in-flight turns - #858

Draft
govindavashishtha wants to merge 2 commits into
mainfrom
composer-interactive-supersede-turns
Draft

Keep composer interactive and preserve superseded in-flight turns#858
govindavashishtha wants to merge 2 commits into
mainfrom
composer-interactive-supersede-turns

Conversation

@govindavashishtha

@govindavashishtha govindavashishtha commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep the composer mounted and interactive during running and paused turns; Cancel only when busy and empty, Send when there is content (including attachments).
  • A new user send aborts the prior client stream without cancelSession (backend supersedes) and force-commits any half-baked pending user / incomplete assistant as a cancelled turn so it stays in the transcript.
  • Stack pause chrome (ask-user / approvals / MCP) above the composer; abandon interactive pause UI after a later user message. Hosts overriding ComposerSendButton should use hasContent, not only isRunning.

Test plan

  • pnpm --filter @truefoundry/trueforge-assistant-ui-runtime test
  • pnpm --filter @truefoundry/trueforge-ui test (composer container/shell/sections)
  • Mid-stream: send while assistant is streaming — prior user + partial assistant remain (cancelled), new turn continues; Cancel button not used; cancelSession not called
  • Pre-token: second send before any assistant token — first user bubble remains
  • During ask-user / approval pause: composer stays editable; Send supersedes and drops pause chrome; empty busy composer shows Cancel only
  • Enter does not cancel a running turn when the composer is empty

Made with Cursor

@govindavashishtha @cursoragent
Keep composer interactive and preserve superseded in-flight turns.
7fcc6d9 
Send during running/pauses supersedes the prior client stream without cancelSession, stacks pause chrome above the composer, and commits half-baked turns as cancelled so they stay in the transcript.

Co-authored-by: Cursor <cursoragent@cursor.com>
@changeset-bot

changeset-bot Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fb30c05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@truefoundry/trueforge-ui Patch
@truefoundry/trueforge-assistant-ui-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@govindavashishtha
feat: polish MCP auth and Ask User interface
fb30c05 
- Introduced lettered options (A/B/C) for Ask User prompts, enhancing user interaction.
- Updated button labels to "Continue" for clarity.
- Added new color variable `--color-gray-850` for improved styling.
- Adjusted layout for better alignment of components in the MCP auth and Ask User prompts.

This update aims to enhance the user experience by providing clearer options and a more polished interface.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayan-truefoundry sayan-truefoundry Awaiting requested review from sayan-truefoundry sayan-truefoundry will be requested when the pull request is marked ready for review sayan-truefoundry is a code owner
@qaifi-tf qaifi-tf Awaiting requested review from qaifi-tf qaifi-tf will be requested when the pull request is marked ready for review qaifi-tf is a code owner
@vinit-truefoundry vinit-truefoundry Awaiting requested review from vinit-truefoundry vinit-truefoundry will be requested when the pull request is marked ready for review vinit-truefoundry is a code owner
@kumarsks619 kumarsks619 Awaiting requested review from kumarsks619 kumarsks619 will be requested when the pull request is marked ready for review kumarsks619 is a code owner
@sajal-truefoundry sajal-truefoundry Awaiting requested review from sajal-truefoundry sajal-truefoundry will be requested when the pull request is marked ready for review sajal-truefoundry is a code owner
@debajyoti-truefoundry debajyoti-truefoundry Awaiting requested review from debajyoti-truefoundry debajyoti-truefoundry will be requested when the pull request is marked ready for review debajyoti-truefoundry is a code owner
@chiragjn chiragjn Awaiting requested review from chiragjn chiragjn will be requested when the pull request is marked ready for review chiragjn is a code owner
@heerambavi1998 heerambavi1998 Awaiting requested review from heerambavi1998 heerambavi1998 will be requested when the pull request is marked ready for review heerambavi1998 is a code owner
@sr07asthana sr07asthana Awaiting requested review from sr07asthana sr07asthana will be requested when the pull request is marked ready for review sr07asthana is a code owner
@bhaveshpatel640 bhaveshpatel640 Awaiting requested review from bhaveshpatel640 bhaveshpatel640 will be requested when the pull request is marked ready for review bhaveshpatel640 is a code owner
@thesujai thesujai Awaiting requested review from thesujai thesujai will be requested when the pull request is marked ready for review thesujai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@govindavashishtha