Repository navigation
Add OBS-009..012 for agent-reliability-otel-labels label correctness - #184
Open
ericksondelacruz wants to merge 1 commit into
Open
ericksondelacruz wants to merge 1 commit into
ericksondelacruz wants to merge 1 commit into
Conversation
… correctness OBS-009 (shared Run, medium), OBS-010 (tool span labelled only on success, low), OBS-011 (constant attempt, low) and OBS-012 (run end only on success, low). New engine predicates raise schema_version from 22 to 23 (main took 22 for LC-116). Do not merge before agent-reliability-otel-labels 0.1.1 is published: the 0.1.0 README example trips OBS-009..012.
ericksondelacruz
requested review from
ivanpaghubasan,
jhumel-code and
sairenchristianbuerano
October 14, 2026 10:40
sairenchristianbuerano
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds OBS-009..012 to
observability/quality.yaml. OBS-006..008 check that the agent-reliability-otel-labels labels are written at all; these four repo-scope rules check that they are correct:Runis shared between runs: built at module scope, in a class body, or as a Python default argument, or given a literal run idattemptas a constantEach rule is gated on observability being initialized and on the library being in use. Findings point at the offending call.
manifest.yamlraisesschema_versionfrom 22 to 23, because the rules use four new engine predicates andmainalready took 22 for LC-116.Checks
scripts/check-rules-sync.shin agent-reliability-analyzer, run against this branch: in sync, 128 files, 338 rules.Merge order