Repository navigation
docs(tool_call_claims): rationale for the EBTE tool-call-claims rules - #156
Merged
Merged
Conversation
Rationale docs for OAI-034..036, MCP-033..035 and LC-028..030: a side-effecting tool with no structured claim, a claim nothing checks, and a claim that is only written out or returned. Regenerated the policy indexes for the 349-rule pack.
OAI-034 / MCP-033 / LC-028 move from low to info in the rules pack. The rationale now says why: the pattern has no adoption yet, and info never fails --strict. POLICY_INDEX files regenerated.
2 of 3 tasks
ericksondelacruz
requested review from
ivanpaghubasan,
jhumel-code and
sairenchristianbuerano
October 22, 2026 10:16
Main added OBS-009..012 (#133). POLICY_INDEX.md conflicted; it is generated, so it is regenerated against the merged rules branch (347 -> 356 rules) instead of resolved by hand.
POLICY_INDEX.md conflicted on the totals and row numbers; regenerated with tools/gen_index.py against the rules branch (364 rules).
3 of 4 tasks
sairenchristianbuerano
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale docs for the nine EBTE (Explanation-Bound Tool Execution) tool-call-claims rules:
docs/Policy/openai_sdk/tool_call_claims.md(OAI-034..036)docs/Policy/mcp/tool_call_claims.md(MCP-033..035)docs/Policy/langchain/tool_call_claims.md(LC-028..030)Each doc covers what a claim is, what each rule fires on, why the no-claim rule is info while the other two are medium, and how to fix a finding.
The root and per-SDK
POLICY_INDEX.mdfiles are regenerated withgen_index.py(355 → 364 rules, after mergingmain). The large diff in the root index comes from renumbering the rows after the inserted ones; no existing rule changed.Notes for review
Test plan
Run against the rules repo at
feat/analyzer-ebte-claims:tools/check_rulebook.py --strict:OK: rulebook consistent (0 warning(s))tools/check_links.py: every internal link and anchor resolvestools/gen_index.py --check:OK: 15 index file(s) up to date (364 rules)