Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions mcp/tool_definition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,55 +102,3 @@ rules:
fix: >
Provide a concise `description` string in the registration config stating
what the tool does and when a model should call it.

- id: MCP-015
title: Go MCP tool has no description
severity: low
confidence: 0.85
language: go
applies_to:
- mcp_tool
scope: tool
match:
has_docstring: false
explanation: >
An MCP server authored in Go advertises each tool's description to
connecting clients as the text a model uses to decide whether to call it. A
`mcp.NewTool("name", ...)` with no `mcp.WithDescription(...)` option (or an
`mcp.Tool{...}` whose `Description` is empty) gives every connecting model
nothing to route on, causing wrong-tool or skipped calls across all clients
of the server.
fix: >
Add `mcp.WithDescription("...")` to the `mcp.NewTool(...)` call (mark3labs/
mcp-go), or set the `Description` field on the `mcp.Tool` value (the
official go-sdk), stating what the tool does and when a model should call
it.

- id: MCP-016
title: Ambiguous Go MCP tool name
severity: low
confidence: 0.85
language: go
applies_to:
- mcp_tool
scope: tool
match:
name_in:
- process
- handle
- run
- do
- execute
- perform
- work
- thing
- stuff
explanation: >
A Go MCP tool's name is the first argument to `mcp.NewTool(...)` (or the
`Name` field of an `mcp.Tool`). Names like `process`, `handle`, or `run`
give a connecting model no signal about intent. Because an MCP server is
consumed by clients the author does not control, an ambiguous name degrades
tool selection everywhere the server is mounted and collides more easily
with similarly-named tools from other servers in the same session.
fix: >
Rename to a verb-object form, e.g. `summarize_invoice`, `fetch_weather`.