Skip to content

Fix eager run in adjoint #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ccuetom merged 2 commits into from
Feb 3, 2026
Merged

Fix eager run in adjoint #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c27079
Fix eager run in adjoint
ccuetom Feb 3, 2026
7d8c688
Handle None runtime
ccuetom Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions stride/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,10 @@ def _dealloc(*args):
returns = []
parallel_returns = []
deallocs = []
try:
self_uid = mosaic.runtime().uid
except AttributeError:
self_uid = None
for node in self.graph.toposort(self.prev_op):
kwargs_ = kwargs.copy()

Expand All @@ -356,27 +360,36 @@ def _dealloc(*args):
# call adjoint method
try:
method = getattr(node.op, node.method)
is_proxy = isinstance(node.op, TesseraProxy)
except AttributeError:
method = getattr(node.op.obj, node.method)
is_proxy = isinstance(node.op.obj, TesseraProxy)

if hasattr(node.op, 'is_parameter') and node.op.is_parameter:
redux_grad = await runtime.exec('redux-%s' % node.op.uid, redux, output_grads)
ret = method((redux_grad,), **{**kwargs_, **{'eager': True, 'redux': True}})

else:
ret = method(*output_grads, **kwargs_)
if is_proxy:
ret = method(*output_grads, **{**kwargs_, **{'eager': True}})
else:
ret = method(*output_grads, **kwargs_)

if inspect.iscoroutine(ret) or inspect.iscoroutinefunction(ret):
ret = await ret

if isinstance(ret, TaskProxy):
if len(deallocs):
ret.add_done_callback(dealloc(deallocs))

if (not hasattr(node.op, 'has_tessera') or not node.op.has_tessera or not node.op.is_proxy) and \
(not hasattr(node.op, 'is_parameter') or not node.op.is_parameter):
returns.append(ret)
if ret.runtime_id == self_uid:
ret = await ret
else:
parallel_returns.append(ret)
if len(deallocs):
ret.add_done_callback(dealloc(deallocs))

if (not hasattr(node.op, 'has_tessera') or not node.op.has_tessera or not node.op.is_proxy) and \
(not hasattr(node.op, 'is_parameter') or not node.op.is_parameter):
returns.append(ret)
else:
parallel_returns.append(ret)

input_grads = ret.outputs
else:
Expand Down