Add Smart Label port 10 active GNSS uplink decoder.#191
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds SmartLabel v1 port 10 GNSS uplink support: new ChangesPort 10 GNSS Decoder Implementation
Secrets Detection Baseline Update
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/decoder/smartlabel/v1/port10.go`:
- Line 37: The Satellites field's validation is too strict and rejects valid
GNSS packets reporting 0–2 satellites; update the struct tag on Satellites (the
Satellites *uint8 field in port10.go) to either remove the validate tag entirely
or change it to allow 0 (e.g., validate:"gte=0,lte=27") so packets with 0–2
satellites are accepted while still capping at 27.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ef5fefc3-e821-4e91-b1f2-b5d6957c7c99
📒 Files selected for processing (4)
.secrets.baselinepkg/decoder/smartlabel/v1/decoder.gopkg/decoder/smartlabel/v1/decoder_test.gopkg/decoder/smartlabel/v1/port10.go
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Decode lorawan_gps_ul_ts_t (20-byte fix with status, lat/lon, altitude, timestamp, battery, TTF, PDOP, and satellites) and register GNSS/timestamp/battery features. Includes Zurich sample regression test. Co-authored-by: Cursor <cursoragent@cursor.com>
2668aee to
c3b8529
Compare
Use centimeters on the wire (divide by 100 for meters) instead of the Tag SL 1/10 meter convention. Zurich sample now decodes to ~418 m. Co-authored-by: Cursor <cursoragent@cursor.com>
Decode lorawan_gps_ul_ts_t (20-byte fix with status, lat/lon, altitude, timestamp, battery, TTF, PDOP, and satellites) and register GNSS/timestamp/battery features. Includes Zurich sample regression test.
Summary by CodeRabbit
New Features
Tests
Chores