Skip to content

fix(hooks): honor pre-commit filenames in values-check & avoid set -e abort #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelbeutler merged 1 commit into from
May 20, 2026
Merged

fix(hooks): honor pre-commit filenames in values-check & avoid set -e abort #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/hooks/values-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ set -e

echo "🔍 Validating values.yaml files..."

# Get changed values.yaml files
changed_values=$(git diff --cached --name-only | grep "values\.yaml$")
# pre-commit passes the matched files as arguments; fall back to staged
# values.yaml when invoked directly (e.g. as a manual git hook with no args).
# The `|| true` keeps `set -e` from aborting when grep finds no match.
if [ "$#" -gt 0 ]; then
changed_values=$(printf '%s\n' "$@" | grep "values\.yaml$" || true)
else
changed_values=$(git diff --cached --name-only | grep "values\.yaml$" || true)
fi

if [ -z "$changed_values" ]; then
echo "✅ No values.yaml changes detected"
Expand Down
Loading