Skip to content

fix: restore shitpost card on texts - #112

Merged
trvny merged 1 commit into
mainfrom
fix/shitpost-card
Oct 1, 2026
Merged

trvny merged 1 commit into
mainfrom
fix/shitpost-card

Conversation

@trvny

@trvny trvny commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Injects the newest Shitpost Reactor card directly before #text-list instead of relying on a missing placeholder. The page still degrades cleanly when the feed is unavailable.

Summary by CodeRabbit

  • 界面调整
    • 每日趣帖卡片现在会显示在文章列表中,并排在普通文章之前。
    • 原先独立的每日趣帖展示区域已取消;若没有趣帖或普通文章,列表不会显示对应内容。

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@deepsource-io

deepsource-io Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 2aa61d7...f3ff7f1 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Oct 1, 2026 11:50p.m. Review ↗
Python Oct 1, 2026 11:50p.m. Review ↗
Shell Oct 1, 2026 11:50p.m. Review ↗
SQL Oct 1, 2026 11:50p.m. Review ↗
Secrets Oct 1, 2026 11:50p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@mergify

mergify Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ JAVASCRIPT eslint 1 0 0 0 0.79s

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a94dfa5d-8ed7-4515-aef5-28e396df231f

📥 Commits

Reviewing files that changed from the base of the PR and between 2aa61d7 and f3ff7f1.

📒 Files selected for processing (1)
  • functions/teksty/index.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

onRequest 现在会在 shitpost 或常规文章有内容时注册一个 #text-list 处理器。存在 shitpost 时,处理器会将其卡片插入列表前。存在常规文章时,处理器会用文章卡片替换列表内容。原有的独立 #shitpost-of-day 处理器已移除。

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f3ff7

Available content is rendered in the intended order, and no actionable merge-blocking behavior is established.

Architecture Summary

Architecture risk: 🔵 Low · up to f3ff7

The change affects 1 system.

Changed systems: functions

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — functions (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in functions/teksty/index.js: The handler now runs when either content source has items. It inserts a shitpost card before #text-list when available and replaces the list contents with regular post cards when available; previously, the shitpost was rendered into #shitpost-of-day by a separate handler, while regular posts independently replaced #text-list.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 50.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 标题明确描述了恢复文本页面中 shitpost 卡片的修复,与主要变更一致。
Description check ✅ Passed 描述说明了将最新 Shitpost Reactor 卡片插入 #text-list 前,并说明了 feed 不可用时的降级行为,与变更内容相关。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

我是小兔,蹦到列表边
看见 shitpost 卡片排在前
常规文章随后出现
一个处理器把内容串连
胡萝卜也为新列表点赞

Comment @coderabbitai help to get the list of available commands.

@trvny
trvny merged commit 8be7183 into main Oct 1, 2026
9 checks passed
@trvny
trvny deleted the fix/shitpost-card branch October 1, 2026 23:54
@kanarek-companion

Copy link
Copy Markdown

🐤 Kanarek · 🟣 merged

main ✅

Main has acquired another resident. Welcome aboard.

Functions · 1 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant