Repository navigation
Conversation
Pending never reads rows of an aborted turn, but OutboxCounts counted them, so `atlas-cli status` (and serve, settings) reported work as waiting to sync that never would, and the pending count could not reach zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pendingnever reads rows of an aborted turn (the desktop marks a turn aborted when the process died inside it), butOutboxCountscounted them. Soatlas-cli status,serveandsettingsreported work as waiting to sync that never would, and the pending count could not reach zero. The desktop's health count has the same fix in pacifio/atlas#502.Evidence
atlas-cli statuson a real store showedSync: ok · 36295 sent, 99 pending, 0 failed. All 99 rows came from aborted turns, withsync_attempts = 0.After: the same store shows
Sync: ok · 36390 sent, 0 pending, 0 failed.TestAbortedTurnRowsAreNotCountedAsPendingmarks the fixture's turn aborted and asserts the pending count equalsPending().Len()(2). Without the fix it fails:pending count 4, outbox holds 2.go vetis clean, andgo test ./internal/capture/... ./cmd/...passes.Merge Danger
Door: two-way
A read-only count change, with no writes and no schema change.
Blast Radius: small
The pending number in
status,settingsandserve's idle check.