Skip to content

fix(app): declare API_URL and APP_URL in the build task env #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
R0drig0Diaz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(app): declare API_URL and APP_URL in the build task env #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/app/turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@
"dependsOn": ["^build"],
"inputs": ["$TURBO_DEFAULT$", ".env*"],
"outputs": [".next/**", "!.next/cache/**", "!.next/dev/**"],
"env": ["NEXT_PUBLIC_API_URL", "NEXT_PUBLIC_AUTH_URL"],
"env": [
"API_URL",

@cubic-dev-ai cubic-dev-ai Bot Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This fix re-declares the root env values by hand instead of merging them, so it stays fragile. Per the Turborepo docs, a per-package turbo.json array field like env completely replaces the root value by default; the documented way to append to the inherited list is the $TURBO_EXTENDS$ microsyntax as the first element. Because this change hardcodes API_URL/APP_URL/NEXT_PUBLIC_API_URL (already in the root build.env) plus NEXT_PUBLIC_AUTH_URL, the next variable added to the root build.env is silently dropped from the app build again — the exact failure class this PR claims to fix. Replace the hardcoded list with $TURBO_EXTENDS$ so future root additions propagate automatically.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At apps/app/turbo.json, line 10:

<comment>This fix re-declares the root env values by hand instead of merging them, so it stays fragile. Per the Turborepo docs, a per-package `turbo.json` array field like `env` completely replaces the root value by default; the documented way to append to the inherited list is the `$TURBO_EXTENDS$` microsyntax as the first element. Because this change hardcodes API_URL/APP_URL/NEXT_PUBLIC_API_URL (already in the root `build.env`) plus NEXT_PUBLIC_AUTH_URL, the next variable added to the root `build.env` is silently dropped from the app build again — the exact failure class this PR claims to fix. Replace the hardcoded list with `$TURBO_EXTENDS$` so future root additions propagate automatically.</comment>

<file context>
@@ -6,7 +6,12 @@
 			"outputs": [".next/**", "!.next/cache/**", "!.next/dev/**"],
-			"env": ["NEXT_PUBLIC_API_URL", "NEXT_PUBLIC_AUTH_URL"],
+			"env": [
+				"API_URL",
+				"APP_URL",
+				"NEXT_PUBLIC_API_URL",
</file context>
Fix with cubic

"APP_URL",
"NEXT_PUBLIC_API_URL",
"NEXT_PUBLIC_AUTH_URL"
],
"passThroughEnv": [
"AGENT_BRIDGE_SECRET",
"AGENT_URL",
Expand Down