Skip to content

fix(ui): add ARIA labels to DataTable buttons #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdiniz97 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

fix(ui): add ARIA labels to DataTable buttons #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/ui/src/components/data-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ export function DataTable<TRow, TSub = unknown>({
variant="ghost"
size="sm"
onClick={() => selection.state.clear()}
aria-label="Clear selection"
>
Clear
</Button>
Expand All @@ -387,6 +388,7 @@ export function DataTable<TRow, TSub = unknown>({
className="w-full justify-between sm:hidden"
aria-expanded={filtersOpen}
aria-controls={filtersId}
aria-label="Toggle filters"
onClick={() => setFiltersOpen((open) => !open)}
>
<span className="flex items-center gap-2">
Expand Down Expand Up @@ -424,6 +426,7 @@ export function DataTable<TRow, TSub = unknown>({
variant="outline"
size="sm"
className="w-full justify-between sm:w-auto sm:min-w-44"
aria-label={`Select tab: ${activeTabLabel}`}
>
<span className="truncate">{activeTabLabel}</span>
<ChevronDown className="shrink-0 opacity-60" />
Expand Down Expand Up @@ -463,6 +466,7 @@ export function DataTable<TRow, TSub = unknown>({
variant="outline"
size="sm"
className="justify-start sm:justify-center"
aria-label="Filter table"
>
<Filter data-icon="inline-start" />
Filters
Expand Down Expand Up @@ -492,6 +496,7 @@ export function DataTable<TRow, TSub = unknown>({
variant="outline"
size="sm"
className="justify-start sm:justify-center"
aria-label="Sort table"
>
<ArrowsVertical data-icon="inline-start" />
Sort
Expand Down Expand Up @@ -538,6 +543,7 @@ export function DataTable<TRow, TSub = unknown>({
variant="outline"
size="sm"
className="justify-start sm:justify-center"
aria-label="Toggle columns"
>
<Column data-icon="inline-start" />
Columns
Expand Down