Conversation
Added disabled prop and ARIA attributes to TokenField, TokenFieldItem, and TokenFieldAction components: - TokenField: disabled prop, aria-disabled, aria-busy attributes - TokenFieldItem: aria-disabled attribute - TokenFieldAction: disabled prop passed to Button Improves UX by allowing disabled states and enhances accessibility for screen readers. Fixes trycompai#220
|
@mdiniz97 is attempting to deploy a commit to the Comp AI - PoC Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/ui/src/components/token-field.tsx">
<violation number="1" location="packages/ui/src/components/token-field.tsx:20">
P2: When a consumer uses the new `TokenField disabled` prop, the field remains interactive because `aria-disabled` does not disable editing or descendant buttons. Propagate the disabled state to editable descendants and actions, or provide a shared state mechanism that those children consume.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| <div | ||
| data-slot="token-field" | ||
| role="group" | ||
| aria-disabled={ariaDisabled ?? disabled} |
Contributor
There was a problem hiding this comment.
P2: When a consumer uses the new TokenField disabled prop, the field remains interactive because aria-disabled does not disable editing or descendant buttons. Propagate the disabled state to editable descendants and actions, or provide a shared state mechanism that those children consume.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/ui/src/components/token-field.tsx, line 20:
<comment>When a consumer uses the new `TokenField disabled` prop, the field remains interactive because `aria-disabled` does not disable editing or descendant buttons. Propagate the disabled state to editable descendants and actions, or provide a shared state mechanism that those children consume.</comment>
<file context>
@@ -2,13 +2,25 @@ import { Button } from "@crm/ui/components/button";
<div
data-slot="token-field"
role="group"
+ aria-disabled={ariaDisabled ?? disabled}
+ aria-busy={ariaBusy}
className={cn(
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added disabled prop and ARIA attributes to TokenField, TokenFieldItem, and TokenFieldAction components:
Improves UX by allowing disabled states and enhances accessibility for screen readers.
Fixes #220
Summary by cubic
Adds disabled and loading states to the TokenField component so forms can indicate when token editing is unavailable or pending.
TokenFieldnow accepts adisabledprop and forwardsaria-disabledandaria-busyto the root element.TokenFieldItemandTokenFieldActionalso support the disabled state, giving users and screen readers clear feedback. Fixes #220.Written for commit 0deb4da. Summary will update on new commits.