Importruns: introduce data contracts for run log and metadata#336
Open
ol-nata wants to merge 4 commits into
Open
Importruns: introduce data contracts for run log and metadata#336ol-nata wants to merge 4 commits into
ol-nata wants to merge 4 commits into
Conversation
Add a JSON schema for the run log in JSON format, matching the import pipeline and the current log format produced by TE. Serves as a data contract at the boundary between Bublik and TE. Signed-off-by: Natalia Rybchenko <natalia.rybchenko@oktetlabs.ru>
Validate downloaded run logs against the schema before processing them further, so a malformed log is rejected early with a clear error instead of failing deep inside the import pipeline. Signed-off-by: Natalia Rybchenko <natalia.rybchenko@oktetlabs.ru>
Add a JSON schema for meta_data.json, matching the format produced by test-environment's metadata generator (scripts/lib.meta). Serves as a data contract at the boundary between Bublik and TE, alongside the run log schema. Signed-off-by: Natalia Rybchenko <natalia.rybchenko@oktetlabs.ru>
Validate downloaded meta_data.json against the schema before passing it on for processing, so malformed metadata is rejected early with a clear error instead of failing deep inside the import pipeline. Locally generated meta_data.json (produced when none is provided by the run source) is not validated, since it comes from a trusted project-local script rather than external input. Signed-off-by: Natalia Rybchenko <natalia.rybchenko@oktetlabs.ru>
Collaborator
|
I would suggest to add meta_data.json schema as part of this PR or separate one since I think it's important piece of data for import process. |
okt-konst
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces JSON schemas for the run log and metadata formats as data contracts at the boundary between Bublik and TE, and enforces them during import.