engine/rcf: allow reboot of dynamically added agents#10
Open
okt-konst wants to merge 1 commit into
Open
Conversation
A TA added at runtime via rcf_add_ta_unix() with RCF_TA_REBOOTABLE
could never be rebooted: rcf_ta_reboot() always failed with
RCF-EOPNOTSUPP ("None of the requested reboot types are allowed")
because the RCFOP_ADD_TA path never initializes
reboot_ctx.allowed_types (the agent struct is zero-allocated),
while the rcf.conf parse path defaults it to all reboot types when
the reboot_types attribute is absent.
Apply the same all-types default to dynamic TAs; rebootability is
still guarded by the RCF_TA_REBOOTABLE flag (TE_EPERM otherwise).
Signed-off-by: Konstantin Ushakov <kushakov@oktet.co.il>
Collaborator
Author
|
@ol-arteman @arybchik could you please review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A TA added at runtime via rcf_add_ta_unix() with RCF_TA_REBOOTABLE could
never be rebooted: rcf_ta_reboot() always failed with RCF-EOPNOTSUPP
("None of the requested reboot types are allowed") because the RCFOP_ADD_TA
path never initializes reboot_ctx.allowed_types (the agent struct is
zero-allocated), while the rcf.conf parse path defaults it to all reboot
types when the reboot_types attribute is absent.
Apply the same all-types default to dynamic TAs; rebootability is still
guarded by the RCF_TA_REBOOTABLE flag (TE_EPERM otherwise).