lib/tapi_tool: redis/valkey server and benchmark improvements#12
Open
okt-konst wants to merge 3 commits into
Open
lib/tapi_tool: redis/valkey server and benchmark improvements#12okt-konst wants to merge 3 commits into
okt-konst wants to merge 3 commits into
Conversation
Needed to benchmark valkey the way it is run in production experiments: persistence off (save "") and the event loop pinned to a fixed CPU. Both directives are understood by redis >= 6 and valkey. New fields default to NULL (omitted), so existing users are unaffected. Signed-off-by: Konstantin Ushakov <konstantin.ushakov@oktet.tech>
valkey-benchmark adds --duration/--warmup (time-based runs instead of request counts) and extends --csv output with latency percentile columns. Add the options and a CSV report parser filling new latency fields in tapi_redis_benchmark_stat; MI-log the percentiles. The plain-output parsing path is unchanged. Signed-off-by: Konstantin Ushakov <konstantin.ushakov@oktet.tech>
A concatenated "--save " token with an empty value trips the redis >= 7.0.1 argv processing: the token splits to a single word, so the server expects the save value in the NEXT argv element, and the "--save" compatibility special case does not match because of the trailing space. The following option then gets consumed as the save value (observed on a live rig as 'save "--server-cpulist 1"' - Invalid save parameters). Separate argv elements produce the documented CLI forms --save "" and --save "3600 1". Signed-off-by: Konstantin Ushakov <konstantin.ushakov@oktet.tech>
Collaborator
Author
|
@ol-arteman @arybchik could you please review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to the redis/valkey TAPI needed for valkey benchmarking:
schedule control and CPU pinning)
per-test results from CSV output
"--save " token trips redis >= 7.0.1 argv processing and the
following option gets consumed as the save value
Commits: