Skip to content

Reduce duplicate 3D model loading for cachebusted URLs#897

Open
itsdior01 wants to merge 1 commit into
tscircuit:mainfrom
itsdior01:bounty/09138e26fdb6-improve-3d-model-loading
Open

Reduce duplicate 3D model loading for cachebusted URLs#897
itsdior01 wants to merge 1 commit into
tscircuit:mainfrom
itsdior01:bounty/09138e26fdb6-improve-3d-model-loading

Conversation

@itsdior01
Copy link
Copy Markdown

Summary

  • Reuse the same loaded 3D model when only cachebust_origin changes in the model URL.
  • Add a unit test covering repeated model URLs.
  • Keep other URL parameters in the model identity so different models still load separately.

Fixes #93

Checks

  • Passed: bun test tests/global-obj-loader.test.ts
  • Passed: changed files format check
  • Passed: npm run build
  • Passed: npm run test:node-bundle

Note: the full bun test suite still has unrelated board/SVG failures that were not touched by this change.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment May 20, 2026 1:22am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve 3d model loading to avoid laggy browser

1 participant