Dispose MixedStlModel fallback resources#898
Open
swhan0329 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Review-ready follow-up: all attached checks are green on this PR ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #93
Summary
MixedStlModelis rendering its locally-owned red fallback mesh or a loaded cached model.Why
When a board has many duplicate or slow-loading models,
MixedStlModelcreates fallback meshes while the model loader is pending. The transform graph removes those placeholders when the real model arrives, but the placeholder geometry/material were not disposed. The follow-up also closes a small STEP cache reuse gap where a cached GLB could create another blob URL even though the global conversion registry already had one for the same STEP URL.Verification
bun test tests/step-model-cache.test.ts tests/dispose-owned-object-resources.test.tsbun run format:checkbunx tsc --noEmitbun run buildbun run test:node-bundlegit diff --checkFull test note
bun testpreviously had 3 failures unrelated to this change in this checkout:tests/preprocess-circuit-json.test.ts: expected faux-board z offsets are 0.1 higher than current output.tests/outline-bounds.test.ts: expected soldermask color string does not match current rendered SVG color.AI-assisted with Codex; I reviewed the diff and verification output before opening and updating this PR.