Skip to content

Fix #93: normalize 3D model cache keys#902

Open
SimplyRayYZL wants to merge 1 commit into
tscircuit:mainfrom
SimplyRayYZL:fix/93-normalize-model-cache
Open

Fix #93: normalize 3D model cache keys#902
SimplyRayYZL wants to merge 1 commit into
tscircuit:mainfrom
SimplyRayYZL:fix/93-normalize-model-cache

Conversation

@SimplyRayYZL
Copy link
Copy Markdown

Summary

  • Normalizes OBJ/WRL loader cache keys through URL before looking up the global model cache.
  • Removes cachebust_origin and URL hash fragments so duplicate model URLs reuse the same cache entry instead of reloading duplicate models.
  • Deletes failed loads from the cache, allowing transient network/parse failures to retry instead of poisoning the cache.

Validation

  • bun install
  • bunx biome check src/hooks/use-global-obj-loader.ts
  • bun run build
  • bun run test:node-bundle
  • git diff --check

/claim #93

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment May 20, 2026 4:15am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants