Skip to content

Guard stale STL model loads#904

Open
shriram-svg wants to merge 1 commit into
tscircuit:mainfrom
shriram-svg:codex/stlmodel-stale-load-guard
Open

Guard stale STL model loads#904
shriram-svg wants to merge 1 commit into
tscircuit:mainfrom
shriram-svg:codex/stlmodel-stale-load-guard

Conversation

@shriram-svg
Copy link
Copy Markdown

/claim #93

Summary

  • Guard STLModel async STL loader callbacks so late results after stlUrl/stlData changes do not update component state.
  • Dispose geometry that resolves after the component/effect has already cleaned up.
  • Remove the unused mtlUrl prop and update material disposal to satisfy the touched-file Biome check.

Verification

  • bunx biome check src/three-components/STLModel.tsx
  • bun test tests/cad-model-transform.test.ts tests/resolve-model-url.test.ts
  • bun run build
  • bun run test:node-bundle
  • git diff --check

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment May 20, 2026 6:23am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants