Dispose temporary STEP export resources#906
Open
zergzorg wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: zergzorg <kaluga@me.com>
Author
|
Follow-up hardening pushed in
Validation:
|
Author
|
Follow-up hardening pushed in
Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #93
Summary
MeshPhysicalMaterialtexture disposal pathsEffect
The STEP conversion path builds an intermediate THREE.Group only to export a GLB buffer. Before this change, those temporary BufferGeometry, Material, and Texture objects stayed undisposed after export, so repeated STEP loads could keep GPU-side resources around longer than needed. The GLB cache and rendered model behavior are unchanged.
Scope and non-overlap
This PR is a cleanup/resource-disposal slice for temporary STEP export resources. It complements cache-focused work on issue #93: cache changes reduce repeated loading, while this PR makes sure the intermediate Three.js resources created during STEP export are released whether export succeeds or fails.
Validation
bun test tests/dispose-object3d-resources.test.tsbun run buildbunx biome format src/utils/dispose-object3d-resources.ts src/three-components/StepModel.tsx tests/dispose-object3d-resources.test.tsgit diff --checkIssue: #93