Dispose generated model resources on cleanup#907
Open
jeffreybarts-max wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bunx biome check src/utils/dispose-three-object-resources.ts src/three-components/FootprinterModel.tsx src/three-components/JscadModel.tsx tests/dispose-three-object-resources.test.tsbunx tsc --noEmitbun run buildbun run test:node-bundletests/dispose-three-object-resources.test.tswithout the global snapshot preloadNote: the default repo-wide
bun testpath is blocked in this local Windows checkout by the unrelatedsharpnative module used by the snapshot preload, so I validated the new test in isolation plus the package build/type/bundle checks above./claim #93