Skip to content

Fix glTF model lifecycle cleanup#919

Open
kpoxo6op wants to merge 1 commit into
tscircuit:mainfrom
kpoxo6op:codex/gltf-model-lifecycle-cleanup
Open

Fix glTF model lifecycle cleanup#919
kpoxo6op wants to merge 1 commit into
tscircuit:mainfrom
kpoxo6op:codex/gltf-model-lifecycle-cleanup

Conversation

@kpoxo6op
Copy link
Copy Markdown

/claim #93

Summary

  • stop reloading GLTF scenes when only isTranslucent changes
  • clear and dispose previous GLTF scenes on URL replacement/unmount, and dispose late-loaded scenes after cleanup
  • add focused tests for material-state updates and shared resource disposal

Validation

  • npm exec -- bun test tests/gltf-scene-lifecycle.test.ts
  • ./node_modules/.bin/biome check src/utils/gltf-scene-lifecycle.ts src/three-components/GltfModel.tsx tests/gltf-scene-lifecycle.test.ts
  • ./node_modules/.bin/tsc --noEmit --pretty false
  • npm run build
  • git diff --check

Note

  • Full npm exec -- bun test tests currently fails in existing outline-bounds and preprocess-circuit-json assertions outside this patch.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment May 22, 2026 6:14am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant