Clear stale STEP model while new URL loads#928
Open
YunHeTracyLee wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #93
Summary
StepModel's derivedstepGltfUrlat the start of each newstepUrlload, so a previously converted STEP model is removed while the next STEP conversion is pending.Non-overlap
This is scoped to the STEP React lifecycle state for URL changes. It does not add or change STEP cache-key normalization, completed/blob reuse, temporary conversion resource disposal, generic
load3DModelcaching, GLTF lifecycle cleanup, OBJ/WRL loader behavior, or STL handling covered by existing PRs.Validation
npx --yes bun test tests/step-model-url-change.test.tsxwithbunfig.tomltemporarily moved aside to bypass the repo-wide sharp/looks-same preload; focused test passed.npx biome check src/three-components/StepModel.tsx tests/step-model-url-change.test.tsxnpx tsc --noEmit --pretty falsenpm run buildnpm run test:node-bundlegit diff --checkLocal environment note
The default
bun testpreload importslooks-same/sharp; local dependencies were installed with scripts disabled, so the focused React test was run without the unrelated snapshot preload andbunfig.tomlwas restored afterward.AI-assisted with Codex; I reviewed the diff and validation results before submitting.