feat(Port): pass highlightColor from pinAttributes to pcb_port#1900
Open
bimakw wants to merge 1 commit intotscircuit:mainfrom
Open
feat(Port): pass highlightColor from pinAttributes to pcb_port#1900bimakw wants to merge 1 commit intotscircuit:mainfrom
bimakw wants to merge 1 commit intotscircuit:mainfrom
Conversation
- Add _getPinoutHighlightColor() method to read highlightColor from pinAttributes - Include highlight_color in pcb_port during both initial and update renders - Enables custom colors for pinout diagram labels via pinAttributes Part of tscircuit/tscircuit#895
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the
highlightColorfeature for pinout diagrams by passing the color value frompinAttributestopcb_port:_getPinoutHighlightColor()method: ReadshighlightColorfrompinAttributesconfigurationhighlight_colorin pcb_port: Pass the color value during both initial and update rendersTest Plan
Related
Usage Example