fix: clarify invalid footprint function errors#647
Open
ItsOtherMauridian wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #46.
Invalid footprint strings currently throw a generic parser error such as
Invalid footprint function, got "invalid".... This PR makes that diagnostic point to the missing footprinter function directly and suggests valid examples.Example new error:
The same helper is used for both
circuitJson/soupandjsonpaths so the message stays consistent.Test plan
npx bun test tests/string-parser.test.ts tests/fp-string-error.test.ts tests/vssop.test.tsnpm run buildnpx bun test