Skip to content

[codex] Enforce global object limit#116

Open
asim48-ctrl wants to merge 1 commit into
tscircuit:mainfrom
asim48-ctrl:codex/global-object-limit
Open

[codex] Enforce global object limit#116
asim48-ctrl wants to merge 1 commit into
tscircuit:mainfrom
asim48-ctrl:codex/global-object-limit

Conversation

@asim48-ctrl
Copy link
Copy Markdown

/claim #42

Summary

  • enforce objectLimit globally across rendered object groups after filters are applied
  • keep the warning based on the pre-limit filtered object count
  • show the warning whenever the limit is reached, even if step controls are not visible
  • add focused tests for the shared limiter

Validation

  • npx --yes bun@1.2.17 test tests/limitFilteredObjects.test.ts
  • npx --yes bun@1.2.17 test
  • npx --yes bun@1.2.17 run format:check
  • npx --yes bun@1.2.17 run build

Demo note: the existing interactive-object-limit-layer-and-step-filtering fixture now caps to 3 total rendered objects instead of allowing up to 3 per object type.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
graphics-debug Ready Ready Preview, Comment May 10, 2026 9:58pm

Request Review

@asim48-ctrl
Copy link
Copy Markdown
Author

Demo video for the UI bounty requirement:

objectLimit demo

This uses the existing interactive-object-limit-layer-and-step-filtering fixture: all layers shows Display limited to 3 objects. Received: 4., switching to layer1 removes the warning because the filtered object count is within the limit, and switching back restores the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant