fix(examples): rename DisabledAutoFocus fixture to use focusOnHover={false}#868
Open
dukunline-cyber wants to merge 1 commit into
Open
fix(examples): rename DisabledAutoFocus fixture to use focusOnHover={false}#868dukunline-cyber wants to merge 1 commit into
dukunline-cyber wants to merge 1 commit into
Conversation
Closes tscircuit#163. The legacy DisabledAutoFocus fixture name predates the focusOnHover API. Renames to FocusOnHoverDisabled and makes the intent explicit by passing focusOnHover={false} to PCBViewer.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Quick status update for maintainers:
Ready when you have a moment. Happy to rebase if anything lands first. |
Author
|
/claim #163 |
Author
|
Hi, just following up — any review comments or changes needed? Happy to iterate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #163
Closes #163.
Summary
The
DisabledAutoFocusfixture insrc/examples/2025/board.fixture.tsxis the only remaining reference in the repo to the legacydisableAutoFocusAPI.Changes
DisabledAutoFocus→FocusOnHoverDisabledto match the currentfocusOnHoverAPI surface (consistent with sibling fixtures inhover-behavior.fixture.tsx).focusOnHover={false}prop to<PCBViewer />so the fixture actually exercises the disabled-focus behavior its name implies (previously the prop was missing entirely, which meant it relied on default behavior).Verification
Diff is 2 lines.