Skip to content

fix(examples): rename DisabledAutoFocus fixture to use focusOnHover={false}#868

Open
dukunline-cyber wants to merge 1 commit into
tscircuit:mainfrom
dukunline-cyber:fix/163-rename-disabledautofocus
Open

fix(examples): rename DisabledAutoFocus fixture to use focusOnHover={false}#868
dukunline-cyber wants to merge 1 commit into
tscircuit:mainfrom
dukunline-cyber:fix/163-rename-disabledautofocus

Conversation

@dukunline-cyber
Copy link
Copy Markdown

@dukunline-cyber dukunline-cyber commented May 16, 2026

/claim #163

Closes #163.

Summary

The DisabledAutoFocus fixture in src/examples/2025/board.fixture.tsx is the only remaining reference in the repo to the legacy disableAutoFocus API.

Changes

  • Renames the fixture export DisabledAutoFocusFocusOnHoverDisabled to match the current focusOnHover API surface (consistent with sibling fixtures in hover-behavior.fixture.tsx).
  • Adds focusOnHover={false} prop to <PCBViewer /> so the fixture actually exercises the disabled-focus behavior its name implies (previously the prop was missing entirely, which meant it relied on default behavior).

Verification

$ grep -rn "DisabledAutoFocus\|disableAutoFocus" --include="*.tsx" --include="*.ts" .
# (no matches after this PR)

Diff is 2 lines.

Closes tscircuit#163. The legacy DisabledAutoFocus fixture name predates the focusOnHover API. Renames to FocusOnHoverDisabled and makes the intent explicit by passing focusOnHover={false} to PCBViewer.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pcb-viewer Ready Ready Preview, Comment May 16, 2026 7:57pm

Request Review

@dukunline-cyber
Copy link
Copy Markdown
Author

Quick status update for maintainers:

  • ✅ Both CI checks green
  • ✅ Mergeable, no conflicts
  • ✅ Diff is 2 lines (the rename + the prop addition)
  • ✅ Verified zero remaining disableAutoFocus / DisabledAutoFocus references in the repo via grep -rn

Ready when you have a moment. Happy to rebase if anything lands first.

@dukunline-cyber
Copy link
Copy Markdown
Author

/claim #163

@dukunline-cyber
Copy link
Copy Markdown
Author

Hi, just following up — any review comments or changes needed? Happy to iterate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove disableAutoFocus in favor of focusOnHover={false}

1 participant